Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Conversation

@weikengchen
Copy link
Contributor

Just start to try Key Transparency (just work-in-progress? I can't wait to use it)

I find that when I want to post a public key, there will be a notice "please enter a master key", but post.go does not accept the password -p as input.

Just start to try Key Transparency (just work-in-progress? I can't wait to use it)

I find that when I want to post a public key, there will be a notice "please enter a master key", but post.go does not accept the password `-p` as input.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@weikengchen
Copy link
Contributor Author

A side question: is Key Transparency ready to an extent that a class project can launch a server and create a local key Merkle tree?

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

Codecov Report

Merging #971 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   47.34%   47.34%           
=======================================
  Files          28       28           
  Lines        2034     2034           
=======================================
  Hits          963      963           
  Misses        894      894           
  Partials      177      177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9701801...75b8aa2. Read the comment docs.

@gdbelvin
Copy link
Contributor

gdbelvin commented May 8, 2018

Hi @weikengchen, thanks for spotting and fixing this!

Key Transparency is ready for prototyping and classroom use.
Key Transparency is in the middle of polishing and tuning so it can be used in production.

@gdbelvin gdbelvin merged commit a662a3e into google:master May 8, 2018
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request May 11, 2018
…y into test/listhistory

* 'test/listhistory' of github.com:gdbelvin/keytransparency:
  Missing masterPassword input in post.go (google#971)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants