This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Use DomainID rather than mapID during authorization #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
==========================================
- Coverage 46.92% 46.87% -0.05%
==========================================
Files 28 28
Lines 2018 2018
==========================================
- Hits 947 946 -1
- Misses 892 893 +1
Partials 179 179
Continue to review full report at Codecov.
|
phad
suggested changes
May 4, 2018
Contributor
phad
left a comment
phad
left a comment
There was a problem hiding this comment.
Minor documentation nit but good to go otherwise.
| message Resource { | ||
| // map_id contains the Key Transparency map identity for this entry. | ||
| int64 map_id = 1; | ||
| string domain_id = 1; |
Contributor
There was a problem hiding this comment.
Comment above is now out of date.
Contributor
Author
|
Done. PTAL |
Contributor
|
This was LGTM with the minor change.
…On Fri, May 4, 2018 at 5:09 PM Gary Belvin ***@***.***> wrote:
Done. PTAL
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#970 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA1WvbhZ1Rgg_pbvV46gtdImCXhZ-zTTks5tvH1CgaJpZM4TxV7b>
.
--
I work a reduced week, from Weds-Fri; messages sent on Mon/Tue will have a
delayed response.
|
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
May 8, 2018
…y into test/listhistory * 'test/listhistory' of github.com:gdbelvin/keytransparency: Use DomainID rather than mapID during authorization (google#970) Strengthen CreateDomain (google#969)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the authorization checks with the domainID/appID resource hierarchy.