This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Update default paths in README #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
=======================================
Coverage 47.34% 47.34%
=======================================
Files 28 28
Lines 2034 2034
=======================================
Hits 963 963
Misses 894 894
Partials 177 177Continue to review full report at Codecov.
|
phad
reviewed
Jan 22, 2018
README.md
Outdated
| - [Proof for app1/[email protected]](https://localhost:8080/v1/domains/default/users/[email protected]?app_id=app1) | ||
| - [Server configuration info](https://localhost:8080/v1/domains/default/info) | ||
| - [Prometheus graphs](http://localhost:9090/graph) | ||
| - [Server configuration info](https://35.225.194.168:8080/v1/domains/default) |
Contributor
There was a problem hiding this comment.
Do you really want these IP addresses published in the documentation?
Contributor
Author
There was a problem hiding this comment.
I'm not sure...
I think it would make it easier for people to play with the server and begin understanding how KT works?
Contributor
Author
|
Reviving this PR. I've updated the IP addresses to be static so they don't change with every server restart. PTAL |
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
May 13, 2018
* master: Move authentication to grpc interceptor (google#973) Add UnitTest for PaginateHistory (google#968) Remove unused `UserProfile` message (google#972) Update default paths (google#910)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update both the README and the default client configuration to point to the continuous integration server.