Rename gometalinter gas to gosec #1024
Conversation
| Vlog.Printf("Warning: Skipping verification of KT Server's TLS certificate.") | ||
| return credentials.NewTLS(&tls.Config{ | ||
| InsecureSkipVerify: true, // nolint: gas | ||
| InsecureSkipVerify: true, // nolint: gosec |
There was a problem hiding this comment.
G402: TLS InsecureSkipVerify set true.
| if insecure { | ||
| return credentials.NewTLS(&tls.Config{ | ||
| InsecureSkipVerify: true, // nolint: gas | ||
| InsecureSkipVerify: true, // nolint: gosec |
There was a problem hiding this comment.
G402: TLS InsecureSkipVerify set true.
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
=======================================
Coverage 65.12% 65.12%
=======================================
Files 39 39
Lines 2707 2707
=======================================
Hits 1763 1763
Misses 630 630
Partials 314 314Continue to review full report at Codecov.
|
| case insecure: // Impatient insecure. | ||
| return credentials.NewTLS(&tls.Config{ | ||
| InsecureSkipVerify: true, // nolint: gas | ||
| InsecureSkipVerify: true, // nolint |
There was a problem hiding this comment.
Why doesn't this line mention the gosec linter? the others in this PR do.
There was a problem hiding this comment.
For some reason, the linter stopped recognizing the nolint with the linter. Why I'm not sure.
phad
left a comment
phad
left a comment
There was a problem hiding this comment.
I'm sure this is fine, but one qq for you .
* master: Implement garbage collection for domains (google#1021) Remove TRILLIAN_MYSQL_DRIVER (google#1023) Rename gometalinter gas to gosec (google#1024) Remove service-key (google#1022)
3 participants
Follows alecthomas/gometalinter#505