This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Remove service-key #1022
Merged
Remove service-key #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the client was not sending oauth user credentials. Post google#975, client creds do not need to be passed with each RPC, and as such, an authenticated, yet anonymous mode of authentication is no longer needed, we can just use unauthenticated calls for the public api. If we need to bring this back at a later point for spam reasons, we can. In the meantime, deleted code is best code.
|
I don't have a great working knowledge of what's needed for fake user creds, but this LGTM and works on my machine. |
davidbstein
approved these changes
Jul 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
=======================================
Coverage 65.12% 65.12%
=======================================
Files 39 39
Lines 2707 2707
=======================================
Hits 1763 1763
Misses 630 630
Partials 314 314Continue to review full report at Codecov.
|
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 25, 2018
…y into f/garbagecollect * 'f/garbagecollect' of github.com:gdbelvin/keytransparency: Remove service-key (google#1022)
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 25, 2018
* master: Implement garbage collection for domains (google#1021) Remove TRILLIAN_MYSQL_DRIVER (google#1023) Rename gometalinter gas to gosec (google#1024) Remove service-key (google#1022)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the client was not sending oauth user credentials.
Post #975, client creds do not need to be passed with each RPC, and as
such, an authenticated, yet anonymous mode of authentication is no
longer needed, we can just use unauthenticated calls for the public api.
If we need to bring this back at a later point for spam reasons, we can.
In the meantime, deleted code is best code.