Add support for androidx.paging #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizgrp
approved these changes
Nov 24, 2022
Member
luizgrp
left a comment
luizgrp
left a comment
There was a problem hiding this comment.
LGTM - screenshot/video in the description would be nice
sample/src/main/java/com/google/android/horologist/paging/PagingScreen.kt
Outdated
Show resolved
Hide resolved
sample/src/main/java/com/google/android/horologist/sample/MenuChips.kt
Outdated
Show resolved
Hide resolved
sample/src/main/java/com/google/android/horologist/paging/PagingScreen.kt
Outdated
Show resolved
Hide resolved
sample/src/main/java/com/google/android/horologist/paging/PagingScreen.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
done |
Member
|
nice! the loading indicator seem static in the vid, are the animations disabled in that device? |
Collaborator
Author
Not sure, I noticed that as well. I'll try on another emulator. |
# Conflicts: # sample/src/main/java/com/google/android/horologist/sample/SampleWearApp.kt # sample/src/main/java/com/google/android/horologist/sample/Screen.kt
Collaborator
Author
|
Some issues with placeholders, but that is sample code only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add support for androidx.paging
WHY
Infinite lists are relevant for message inboxes etc.
HOW
Mostly a port of https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
Checklist 📋
paging.mp4