Repository navigation
Fix primitive array rotations at Integer.MIN_VALUE - #8807
Closed
wozhenbang2004 wants to merge 17 commits into
Closed
wozhenbang2004 wants to merge 17 commits into
wozhenbang2004 wants to merge 17 commits into
Conversation
Add test for rotating with minimum integer value distance.
Add test for rotating array with minimum value distance.
Add test for rotating with minimum integer value distance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primitive array
rotatemethods negate the distance before reducing it modulo the range length. NegatingInteger.MIN_VALUEoverflows, so rotating{1, 2, 3}by that distance produces{2, 3, 1}instead of{3, 1, 2}, unlike the documentedCollections.rotateequivalent.Reduce the distance modulo the range length before negating it in all eight primitive implementations. Add regression coverage for both whole-array and indexed rotations in each existing test class. No public API changes.
Validation:
Collections.rotate: eight primitive types, lengths 0–15, every subrange, and ten distances includingInteger.MIN_VALUE, its next value, andInteger.MAX_VALUE. The original code had 2,728 mismatches; the fix had none.