Skip to content

Commit 6b2e749

Browse files
Abseil Teamderekmauro
Abseil Team
authored and
derekmauro
committed
Googletest export
Print unique_ptr/shared_ptr recursively. Given that they are smart pointers, it is unlikely that the inner object is invalid. PiperOrigin-RevId: 351586888
1 parent 50ce520 commit 6b2e749

File tree

2 files changed

+92
-2
lines changed

2 files changed

+92
-2
lines changed

‎googletest/include/gtest/gtest-printers.h

+39
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,15 @@
101101
#define GTEST_INCLUDE_GTEST_GTEST_PRINTERS_H_
102102

103103
#include <functional>
104+
#include <memory>
104105
#include <ostream> // NOLINT
105106
#include <sstream>
106107
#include <string>
107108
#include <tuple>
108109
#include <type_traits>
109110
#include <utility>
110111
#include <vector>
112+
111113
#include "gtest/internal/gtest-internal.h"
112114
#include "gtest/internal/gtest-port.h"
113115

@@ -573,6 +575,43 @@ void PrintTo(std::reference_wrapper<T> ref, ::std::ostream* os) {
573575
UniversalPrinter<T&>::Print(ref.get(), os);
574576
}
575577

578+
inline const void* VoidifyPointer(const void* p) { return p; }
579+
inline const void* VoidifyPointer(volatile const void* p) {
580+
return const_cast<const void*>(p);
581+
}
582+
583+
template <typename T, typename Ptr>
584+
void PrintSmartPointer(const Ptr& ptr, std::ostream* os, char) {
585+
if (ptr == nullptr) {
586+
*os << "(nullptr)";
587+
} else {
588+
// We can't print the value. Just print the pointer..
589+
*os << "(" << (VoidifyPointer)(ptr.get()) << ")";
590+
}
591+
}
592+
template <typename T, typename Ptr,
593+
typename = typename std::enable_if<!std::is_void<T>::value &&
594+
!std::is_array<T>::value>::type>
595+
void PrintSmartPointer(const Ptr& ptr, std::ostream* os, int) {
596+
if (ptr == nullptr) {
597+
*os << "(nullptr)";
598+
} else {
599+
*os << "(ptr = " << (VoidifyPointer)(ptr.get()) << ", value = ";
600+
UniversalPrinter<T>::Print(*ptr, os);
601+
*os << ")";
602+
}
603+
}
604+
605+
template <typename T, typename D>
606+
void PrintTo(const std::unique_ptr<T, D>& ptr, std::ostream* os) {
607+
(PrintSmartPointer<T>)(ptr, os, 0);
608+
}
609+
610+
template <typename T>
611+
void PrintTo(const std::shared_ptr<T>& ptr, std::ostream* os) {
612+
(PrintSmartPointer<T>)(ptr, os, 0);
613+
}
614+
576615
// Helper function for printing a tuple. T must be instantiated with
577616
// a tuple type.
578617
template <typename T>

‎googletest/test/googletest-printers-test.cc

+53-2
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,16 @@
3232
//
3333
// This file tests the universal value printer.
3434

35-
#include <ctype.h>
36-
#include <string.h>
3735
#include <algorithm>
36+
#include <cctype>
3837
#include <cstdint>
38+
#include <cstring>
3939
#include <deque>
4040
#include <forward_list>
4141
#include <limits>
4242
#include <list>
4343
#include <map>
44+
#include <memory>
4445
#include <set>
4546
#include <sstream>
4647
#include <string>
@@ -1702,6 +1703,56 @@ TEST(UniversalPrintTest, IncompleteType) {
17021703
PrintToString(reinterpret_cast<Incomplete&>(some_object)));
17031704
}
17041705

1706+
TEST(UniversalPrintTest, SmartPointers) {
1707+
EXPECT_EQ("(nullptr)", PrintToString(std::unique_ptr<int>()));
1708+
std::unique_ptr<int> p(new int(17));
1709+
EXPECT_EQ("(ptr = " + PrintPointer(p.get()) + ", value = 17)",
1710+
PrintToString(p));
1711+
std::unique_ptr<int[]> p2(new int[2]);
1712+
EXPECT_EQ("(" + PrintPointer(p2.get()) + ")", PrintToString(p2));
1713+
1714+
EXPECT_EQ("(nullptr)", PrintToString(std::shared_ptr<int>()));
1715+
std::shared_ptr<int> p3(new int(1979));
1716+
EXPECT_EQ("(ptr = " + PrintPointer(p3.get()) + ", value = 1979)",
1717+
PrintToString(p3));
1718+
#if __cpp_lib_shared_ptr_arrays >= 201611L
1719+
std::shared_ptr<int[]> p4(new int[2]);
1720+
EXPECT_EQ("(" + PrintPointer(p4.get()) + ")", PrintToString(p4));
1721+
#endif
1722+
1723+
// modifiers
1724+
EXPECT_EQ("(nullptr)", PrintToString(std::unique_ptr<int>()));
1725+
EXPECT_EQ("(nullptr)", PrintToString(std::unique_ptr<const int>()));
1726+
EXPECT_EQ("(nullptr)", PrintToString(std::unique_ptr<volatile int>()));
1727+
EXPECT_EQ("(nullptr)", PrintToString(std::unique_ptr<volatile const int>()));
1728+
EXPECT_EQ("(nullptr)", PrintToString(std::unique_ptr<int[]>()));
1729+
EXPECT_EQ("(nullptr)", PrintToString(std::unique_ptr<const int[]>()));
1730+
EXPECT_EQ("(nullptr)", PrintToString(std::unique_ptr<volatile int[]>()));
1731+
EXPECT_EQ("(nullptr)",
1732+
PrintToString(std::unique_ptr<volatile const int[]>()));
1733+
EXPECT_EQ("(nullptr)", PrintToString(std::shared_ptr<int>()));
1734+
EXPECT_EQ("(nullptr)", PrintToString(std::shared_ptr<const int>()));
1735+
EXPECT_EQ("(nullptr)", PrintToString(std::shared_ptr<volatile int>()));
1736+
EXPECT_EQ("(nullptr)", PrintToString(std::shared_ptr<volatile const int>()));
1737+
#if __cpp_lib_shared_ptr_arrays >= 201611L
1738+
EXPECT_EQ("(nullptr)", PrintToString(std::shared_ptr<int[]>()));
1739+
EXPECT_EQ("(nullptr)", PrintToString(std::shared_ptr<const int[]>()));
1740+
EXPECT_EQ("(nullptr)", PrintToString(std::shared_ptr<volatile int[]>()));
1741+
EXPECT_EQ("(nullptr)",
1742+
PrintToString(std::shared_ptr<volatile const int[]>()));
1743+
#endif
1744+
1745+
// void
1746+
EXPECT_EQ("(nullptr)", PrintToString(std::unique_ptr<void, void (*)(void*)>(
1747+
nullptr, nullptr)));
1748+
EXPECT_EQ("(" + PrintPointer(p.get()) + ")",
1749+
PrintToString(
1750+
std::unique_ptr<void, void (*)(void*)>(p.get(), [](void*) {})));
1751+
EXPECT_EQ("(nullptr)", PrintToString(std::shared_ptr<void>()));
1752+
EXPECT_EQ("(" + PrintPointer(p.get()) + ")",
1753+
PrintToString(std::shared_ptr<void>(p.get(), [](void*) {})));
1754+
}
1755+
17051756
TEST(UniversalTersePrintTupleFieldsToStringsTestWithStd, PrintsEmptyTuple) {
17061757
Strings result = UniversalTersePrintTupleFieldsToStrings(::std::make_tuple());
17071758
EXPECT_EQ(0u, result.size());

0 commit comments

Comments
 (0)