Make the formatJavadoc option public.#512
Closed
nlupien wants to merge 1 commit intogoogle:masterfrom
Closed
Conversation
Right now the formatJavadoc option in the JavaFormatterOptions isn't tag as either public or private so it gets the default package private scope. This change makes it public so other projects using this as a dependency can change this option.
cushon
approved these changes
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the
formatJavadocoption in theJavaFormatterOptionsisn't tag as either public or private so it gets the default package private scope. This change makes it public so other projects using this as a dependency can change this option.In regards to tests, I'm not sure how to add the relevant test to validate the scope change but since we don't generally test scope, I assume we can skip them?.