-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add repository target to ruleset #3850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3850 +/- ##
==========================================
- Coverage 92.46% 92.36% -0.11%
==========================================
Files 199 199
Lines 14240 14308 +68
==========================================
+ Hits 13167 13215 +48
- Misses 884 894 +10
- Partials 189 199 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @alexandear - @zyfy29
f8058af to
6ccc68c
Compare
|
@gmlewis sorry for overwriting the last commit, force of habit. |
Signed-off-by: Steve Hipwell <[email protected]>
Signed-off-by: Steve Hipwell <[email protected]>
Signed-off-by: Steve Hipwell <[email protected]>
c2ad7e0 to
21fb8df
Compare
|
@gmlewis I've rebased this PR onto the linter changes. |
|
Thank you, @alexandear! |
|
@gmlewis this functionality is something I'd really appreciate being released soon if at all possible? |
OK, I'll work on cutting a release today. |
|
@stevehipwell - this is now available in v80.0.0: |
* forkstream/master: chore!: Remove `PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabled` field (google#3866) feat: Add support for `copilot_code_review` rule type (google#3857) feat: Implement Enterprise SCIM - Delete Groups or Users (google#3856) feat: Add `advanced_search` parameter to `SearchOptions` (google#3868) fix!: Change Org usage report `Quantity` to `float64` (google#3862) build(deps): Bump actions/checkout from 6.0.0 to 6.0.1 in the actions group (google#3863) build(deps): Bump golang.org/x/sync from 0.18.0 to 0.19.0 in /tools (google#3864) build(deps): Bump golang.org/x/term from 0.37.0 to 0.38.0 in /example (google#3865) feat: Implement Enterprise SCIM - Set Groups or Users (google#3858) feat: Add support for Enterprise Team APIs (google#3861) Bump go-github from v79 to v80 in /scrape (google#3855) Bump version of go-github to v80.0.0 (google#3854) feat: Add repository target to ruleset (google#3850)
This PR adds support for rulesets targeting repositories (otherwise known as repository management policies).
@gmlewis I also removed the usage of reflect in favour of a more manual pattern.