Added update branch API#1187
Merged
gmlewis merged 4 commits intogoogle:masterfrom Jun 9, 2019
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
@gmlewis Could you please review this PR? |
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
- Coverage 70.25% 70.24% -0.02%
==========================================
Files 84 84
Lines 5867 5878 +11
==========================================
+ Hits 4122 4129 +7
- Misses 956 958 +2
- Partials 789 791 +2
Continue to review full report at Codecov.
|
gmlewis
requested changes
Jun 8, 2019
| type PullReqestBranchUpdateOptions struct { | ||
| // ExpectedHeadSha specifies the most recent commit on the pull request's branch. | ||
| // Default value is the SHA of the pull request's current HEAD ref. | ||
| ExpectedHeadSha *string `json:"expected_head_sha,omitempty"` |
Collaborator
There was a problem hiding this comment.
Let's please rename this to ExpectedHeadSHA.
|
|
||
| // UpdateBranch updates the pull request branch with latest upstream changes. | ||
| // | ||
| // This method might return an *AcceptedError and a status code of |
Collaborator
There was a problem hiding this comment.
Please remove the * for consistency.
Contributor
Author
|
@gmlewis Addressed reviews. Hope the commits are squashed while merging. |
vaibhavsingh97
approved these changes
Jun 9, 2019
Contributor
vaibhavsingh97
left a comment
vaibhavsingh97
left a comment
There was a problem hiding this comment.
LGTM, +1.
Good work @waseem18 ! 🎉
Collaborator
|
Thank you, @vaibhavsingh97 for the LGTM. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1183