Add method for updating a pull request review#1177
Merged
gmlewis merged 2 commits intogoogle:masterfrom May 30, 2019
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1177 +/- ##
=========================================
- Coverage 70.2% 70.2% -0.01%
=========================================
Files 84 84
Lines 5844 5857 +13
=========================================
+ Hits 4103 4112 +9
- Misses 954 956 +2
- Partials 787 789 +2
Continue to review full report at Codecov.
|
gmlewis
requested changes
May 26, 2019
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joshuabezaleel!
Just a couple tweaks and then I think we are good to go, please.
| }{Body: body} | ||
| u := fmt.Sprintf("repos/%v/%v/pulls/%d/reviews/%d", owner, repo, number, reviewID) | ||
|
|
||
| req, err := s.client.NewRequest("PATCH", u, opts) |
Collaborator
There was a problem hiding this comment.
This needs to be PUT, not PATCH.
gmlewis
approved these changes
May 27, 2019
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joshuabezaleel!
LGTM.
Awaiting second LGTM before merging.
Collaborator
|
Thank you, @gauntface! |
Contributor
Author
|
Thank you very much, @gmlewis and @gauntface ! :) |
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1174