Add GetTeamBySlug methods in teamsService by adrienzieba · Pull Request #1171 · google/go-github

adrienzieba · 2019-05-16T14:44:07Z

Add a method to call the following endpoint
https://developer.github.com/v3/teams/#get-team-by-name

googlebot · 2019-05-16T14:44:11Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

codecov · 2019-05-16T14:46:19Z

Codecov Report

Merging #1171 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
+ Coverage    70.2%   70.25%   +0.05%     
==========================================
  Files          84       84              
  Lines        5857     5867      +10     
==========================================
+ Hits         4112     4122      +10     
  Misses        956      956              
  Partials      789      789

Impacted Files	Coverage Δ
github/teams.go	`71.75% <100%> (+1.69%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6264c79...36fb317. Read the comment docs.

…om/v3/teams/\#get-team-by-name)

adrienzieba · 2019-05-17T13:39:19Z

My company (AppDirect) signed the CLA. I don't see the information on https://cla.developers.google.com/clas

gmlewis · 2019-05-17T22:09:38Z

~~Hi @willnorris, when you get a chance, can you please check the status of the corporate CLA mentioned above?~~ Also, just FYI... I will be OOO for one week starting tomorrow without internet access, so feel free to moderate as you see fit. @gauntface - just FYI for you too. Thanks!

adrienzieba · 2019-05-17T22:44:30Z

CLA should be good now

googlebot · 2019-05-17T22:44:32Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gmlewis

Thank you, @adrienzieba!

One change request, please, and one question that maybe @gauntface has an opinion about.

gmlewis · 2019-05-17T23:49:35Z

 	return t, resp, nil
 }

+// GetTeamByName fetches a team by slug.


Since the parameter is called slug and your documentation also says slug, and the GitHub docs say "the team's slug", what do you think about calling this method GetTeamBySlug ?
I'm actually fine either way, but I had no clue what a slug was until I looked at the linked GitHub docs.

It was just to use the same name used as title inside the github documentation.
I'm fine changing the name of the method to GetTeamBySlug if needed.

Right... that makes total sense. Let's see what @gauntface thinks.

Sorry for the delay on this - GetTeamBySlug please.

The docs say: /orgs/:org/teams/:team_slug so I would definitely use slug, since it's different from the name.

@gauntface, @gmlewis I renamed the method. Thank you for your review.

adrienzieba · 2019-05-23T12:56:15Z

Any update ?

gmlewis · 2019-05-25T19:56:54Z

@gauntface - do you have an opinion about my comment above?

gauntface

Really sorry for the delay on this.

gauntface · 2019-05-30T18:21:58Z

 	return t, resp, nil
 }

+// GetTeamByName fetches a team by slug.


Sorry for the delay on this - GetTeamBySlug please.

The docs say: /orgs/:org/teams/:team_slug so I would definitely use slug, since it's different from the name.

gmlewis

Thank you, @adrienzieba and @gauntface!
LGTM.

Awaiting second LGTM before merging.

gauntface

👍 and apologies again for being sooo slow.

gmlewis · 2019-05-30T23:50:39Z

No problem, @gauntface! We greatly appreciate all your awesome reviews!
Merging.

Fixes google#1172.

googlebot added the cla: no label May 16, 2019

Add GetTeamByName methods in teamsService (https://developer.github.c…

9f0dfdf

…om/v3/teams/\#get-team-by-name)

adrienzieba force-pushed the add.GetTeamByName branch from 4392098 to 9f0dfdf Compare May 16, 2019 14:59

adrienzieba mentioned this pull request May 16, 2019

Add support to get-team-by-name #1172

Closed

googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels May 17, 2019

gmlewis requested changes May 17, 2019

View reviewed changes

pr-1171: addressing comments

67ba9a1

gauntface suggested changes May 30, 2019

View reviewed changes

adrienzieba force-pushed the add.GetTeamByName branch from dfd7659 to f641ff8 Compare May 30, 2019 18:57

rename to GetTeamBySlug

36fb317

adrienzieba force-pushed the add.GetTeamByName branch from f641ff8 to 36fb317 Compare May 30, 2019 18:58

adrienzieba changed the title ~~Add GetTeamByName methods in teamsService~~ Add GetTeamBySlug methods in teamsService May 30, 2019

gmlewis approved these changes May 30, 2019

View reviewed changes

gauntface approved these changes May 30, 2019

View reviewed changes

gmlewis merged commit 8354c07 into google:master May 30, 2019

n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020

Add GetTeamBySlug methods in teamsService (google#1171)

7f9a5c2

Fixes google#1172.

Conversation

adrienzieba commented May 16, 2019

Uh oh!

googlebot commented May 16, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

codecov Bot commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adrienzieba commented May 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmlewis commented May 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adrienzieba commented May 17, 2019

Uh oh!

googlebot commented May 17, 2019

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gmlewis May 17, 2019

Choose a reason for hiding this comment

Uh oh!

adrienzieba May 18, 2019

Choose a reason for hiding this comment

Uh oh!

gmlewis May 18, 2019

Choose a reason for hiding this comment

Uh oh!

gauntface May 30, 2019

Choose a reason for hiding this comment

Uh oh!

adrienzieba May 30, 2019

Choose a reason for hiding this comment

Uh oh!

adrienzieba commented May 23, 2019

Uh oh!

gmlewis commented May 25, 2019

Uh oh!

gauntface left a comment

Choose a reason for hiding this comment

Uh oh!

gauntface May 30, 2019

Choose a reason for hiding this comment

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

gauntface left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented May 16, 2019 •

edited

Loading

adrienzieba commented May 17, 2019 •

edited

Loading

gmlewis commented May 17, 2019 •

edited

Loading