CheckSuiteEvent and CheckRunEvent: fix doc typos#1168
Merged
gmlewis merged 1 commit intogoogle:masterfrom May 8, 2019
Merged
Conversation
The checks API uses "rerequested" (no dash) rather than "re-requested", as per GitHub API docs: * https://developer.github.com/v3/activity/events/types/#checksuiteevent * https://developer.github.com/v3/activity/events/types/#checkrunevent Also confirmed via actual interactions with the GitHub API -- no dash was present in the action of the events received when a check suite or run is rerequested.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
======================================
Coverage 70.2% 70.2%
======================================
Files 84 84
Lines 5830 5830
======================================
Hits 4093 4093
Misses 952 952
Partials 785 785
Continue to review full report at Codecov.
|
gmlewis
approved these changes
May 8, 2019
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @evanelias!
LGTM.
Merging.
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just fixing minor godoc typos -- the checks API uses "rerequested" (no dash) rather than "re-requested", per GitHub API docs:
Also confirmed via actual interactions with the GitHub API; when a check suite or check run is rerequested, no dash was present in the action string of the events received.
Thanks!