Skip to content

add vulnerability-alerts endpoint#1166

Merged
gmlewis merged 2 commits intogoogle:masterfrom
cpanato:GH-1164
May 13, 2019
Merged

add vulnerability-alerts endpoint#1166
gmlewis merged 2 commits intogoogle:masterfrom
cpanato:GH-1164

Conversation

@cpanato
Copy link
Copy Markdown
Contributor

@cpanato cpanato commented May 7, 2019

Adding vulnerability-alerts endpoint

fixes: #1164

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 7, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2019

Codecov Report

Merging #1166 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1166      +/-   ##
=========================================
+ Coverage    70.2%   70.2%   +<.01%     
=========================================
  Files          84      84              
  Lines        5830    5844      +14     
=========================================
+ Hits         4093    4103      +10     
- Misses        952     954       +2     
- Partials      785     787       +2
Impacted Files Coverage Δ
github/github.go 87.53% <ø> (ø) ⬆️
github/repos.go 67.37% <71.42%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fef44b...e5b3367. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cpanato!
This is looking good... just a few minor changes, please.

Comment thread github/repos.go Outdated
Comment thread github/repos.go Outdated
Comment thread github/repos.go Outdated
Comment thread github/repos.go Outdated
Comment thread github/repos_test.go
@gmlewis gmlewis requested a review from gauntface May 8, 2019 02:20
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cpanato!
LGTM.

Awaiting second LGTM before merging.

Copy link
Copy Markdown
Contributor

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR :)

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented May 13, 2019

Thank you, @gauntface!
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support preview enable or disable vulnerability alerts API for a repository

4 participants