Skip to content

Commit e3028fb

Browse files
gmlewisgmlewis
committed
Change SelectedRepoIDs to []string
Signed-off-by: Glenn Lewis <[email protected]>
1 parent fd22ee9 commit e3028fb

3 files changed

Lines changed: 15 additions & 15 deletions

File tree

‎github/actions_secrets.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ func (s *ActionsService) GetEnvSecret(ctx context.Context, repoID int, env, secr
187187
}
188188

189189
// SelectedRepoIDs are the repository IDs that have access to the secret.
190-
type SelectedRepoIDs []int64
190+
type SelectedRepoIDs []string
191191

192192
// EncryptedSecret represents a secret that is encrypted using a public key.
193193
//

‎github/actions_secrets_test.go‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ func TestActionsService_CreateOrUpdateOrgSecret(t *testing.T) {
429429
mux.HandleFunc("/orgs/o/actions/secrets/NAME", func(w http.ResponseWriter, r *http.Request) {
430430
testMethod(t, r, "PUT")
431431
testHeader(t, r, "Content-Type", "application/json")
432-
testBody(t, r, `{"key_id":"1234","encrypted_value":"QIv=","visibility":"selected","selected_repository_ids":[1296269,1269280]}`+"\n")
432+
testBody(t, r, `{"key_id":"1234","encrypted_value":"QIv=","visibility":"selected","selected_repository_ids":["1296269","1269280"]}`+"\n")
433433
w.WriteHeader(http.StatusCreated)
434434
})
435435

@@ -438,7 +438,7 @@ func TestActionsService_CreateOrUpdateOrgSecret(t *testing.T) {
438438
EncryptedValue: "QIv=",
439439
KeyID: "1234",
440440
Visibility: "selected",
441-
SelectedRepositoryIDs: SelectedRepoIDs{1296269, 1269280},
441+
SelectedRepositoryIDs: SelectedRepoIDs{"1296269", "1269280"},
442442
}
443443
ctx := context.Background()
444444
_, err := client.Actions.CreateOrUpdateOrgSecret(ctx, "o", input)
@@ -505,23 +505,23 @@ func TestActionsService_SetSelectedReposForOrgSecret(t *testing.T) {
505505
mux.HandleFunc("/orgs/o/actions/secrets/NAME/repositories", func(w http.ResponseWriter, r *http.Request) {
506506
testMethod(t, r, "PUT")
507507
testHeader(t, r, "Content-Type", "application/json")
508-
testBody(t, r, `{"selected_repository_ids":[64780797]}`+"\n")
508+
testBody(t, r, `{"selected_repository_ids":["64780797"]}`+"\n")
509509
})
510510

511511
ctx := context.Background()
512-
_, err := client.Actions.SetSelectedReposForOrgSecret(ctx, "o", "NAME", SelectedRepoIDs{64780797})
512+
_, err := client.Actions.SetSelectedReposForOrgSecret(ctx, "o", "NAME", SelectedRepoIDs{"64780797"})
513513
if err != nil {
514514
t.Errorf("Actions.SetSelectedReposForOrgSecret returned error: %v", err)
515515
}
516516

517517
const methodName = "SetSelectedReposForOrgSecret"
518518
testBadOptions(t, methodName, func() (err error) {
519-
_, err = client.Actions.SetSelectedReposForOrgSecret(ctx, "\n", "\n", SelectedRepoIDs{64780797})
519+
_, err = client.Actions.SetSelectedReposForOrgSecret(ctx, "\n", "\n", SelectedRepoIDs{"64780797"})
520520
return err
521521
})
522522

523523
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
524-
return client.Actions.SetSelectedReposForOrgSecret(ctx, "o", "NAME", SelectedRepoIDs{64780797})
524+
return client.Actions.SetSelectedReposForOrgSecret(ctx, "o", "NAME", SelectedRepoIDs{"64780797"})
525525
})
526526
}
527527

@@ -888,14 +888,14 @@ func TestEncryptedSecret_Marshal(t *testing.T) {
888888
KeyID: "kid",
889889
EncryptedValue: "e",
890890
Visibility: "v",
891-
SelectedRepositoryIDs: []int64{1},
891+
SelectedRepositoryIDs: []string{"1"},
892892
}
893893

894894
want := `{
895895
"key_id": "kid",
896896
"encrypted_value": "e",
897897
"visibility": "v",
898-
"selected_repository_ids": [1]
898+
"selected_repository_ids": ["1"]
899899
}`
900900

901901
testJSONMarshal(t, u, want)

‎github/dependabot_secrets_test.go‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ func TestDependabotService_CreateOrUpdateOrgSecret(t *testing.T) {
352352
mux.HandleFunc("/orgs/o/dependabot/secrets/NAME", func(w http.ResponseWriter, r *http.Request) {
353353
testMethod(t, r, "PUT")
354354
testHeader(t, r, "Content-Type", "application/json")
355-
testBody(t, r, `{"key_id":"1234","encrypted_value":"QIv=","visibility":"selected","selected_repository_ids":[1296269,1269280]}`+"\n")
355+
testBody(t, r, `{"key_id":"1234","encrypted_value":"QIv=","visibility":"selected","selected_repository_ids":["1296269","1269280"]}`+"\n")
356356
w.WriteHeader(http.StatusCreated)
357357
})
358358

@@ -361,7 +361,7 @@ func TestDependabotService_CreateOrUpdateOrgSecret(t *testing.T) {
361361
EncryptedValue: "QIv=",
362362
KeyID: "1234",
363363
Visibility: "selected",
364-
SelectedRepositoryIDs: SelectedRepoIDs{1296269, 1269280},
364+
SelectedRepositoryIDs: SelectedRepoIDs{"1296269", "1269280"},
365365
}
366366
ctx := context.Background()
367367
_, err := client.Dependabot.CreateOrUpdateOrgSecret(ctx, "o", input)
@@ -428,23 +428,23 @@ func TestDependabotService_SetSelectedReposForOrgSecret(t *testing.T) {
428428
mux.HandleFunc("/orgs/o/dependabot/secrets/NAME/repositories", func(w http.ResponseWriter, r *http.Request) {
429429
testMethod(t, r, "PUT")
430430
testHeader(t, r, "Content-Type", "application/json")
431-
testBody(t, r, `{"selected_repository_ids":[64780797]}`+"\n")
431+
testBody(t, r, `{"selected_repository_ids":["64780797"]}`+"\n")
432432
})
433433

434434
ctx := context.Background()
435-
_, err := client.Dependabot.SetSelectedReposForOrgSecret(ctx, "o", "NAME", SelectedRepoIDs{64780797})
435+
_, err := client.Dependabot.SetSelectedReposForOrgSecret(ctx, "o", "NAME", SelectedRepoIDs{"64780797"})
436436
if err != nil {
437437
t.Errorf("Dependabot.SetSelectedReposForOrgSecret returned error: %v", err)
438438
}
439439

440440
const methodName = "SetSelectedReposForOrgSecret"
441441
testBadOptions(t, methodName, func() (err error) {
442-
_, err = client.Dependabot.SetSelectedReposForOrgSecret(ctx, "\n", "\n", SelectedRepoIDs{64780797})
442+
_, err = client.Dependabot.SetSelectedReposForOrgSecret(ctx, "\n", "\n", SelectedRepoIDs{"64780797"})
443443
return err
444444
})
445445

446446
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
447-
return client.Dependabot.SetSelectedReposForOrgSecret(ctx, "o", "NAME", SelectedRepoIDs{64780797})
447+
return client.Dependabot.SetSelectedReposForOrgSecret(ctx, "o", "NAME", SelectedRepoIDs{"64780797"})
448448
})
449449
}
450450

0 commit comments

Comments
 (0)