Skip to content

Commit 6e52e87

Browse files
committed
Remove mediaTypeGraphQLNodeIDPreview from custom accept headers for DownloadReleaseAsset()
Fixes #870
1 parent 8eefe6b commit 6e52e87

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

‎github/repos_releases.go‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,7 @@ func (s *RepositoriesService) DownloadReleaseAsset(ctx context.Context, owner, r
253253
}
254254

255255
// TODO: remove custom Accept header when APIs fully launch.
256-
acceptHeaders := []string{defaultMediaType, mediaTypeGraphQLNodeIDPreview}
257-
req.Header.Set("Accept", strings.Join(acceptHeaders, ", "))
256+
req.Header.Set("Accept", defaultMediaType)
258257

259258
s.client.clientMu.Lock()
260259
defer s.client.clientMu.Unlock()

‎github/repos_releases_test.go‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -220,10 +220,9 @@ func TestRepositoriesService_DownloadReleaseAsset_Stream(t *testing.T) {
220220
client, mux, _, teardown := setup()
221221
defer teardown()
222222

223-
acceptHeaders := []string{defaultMediaType, mediaTypeGraphQLNodeIDPreview}
224223
mux.HandleFunc("/repos/o/r/releases/assets/1", func(w http.ResponseWriter, r *http.Request) {
225224
testMethod(t, r, "GET")
226-
testHeader(t, r, "Accept", strings.Join(acceptHeaders, ", "))
225+
testHeader(t, r, "Accept", defaultMediaType)
227226
w.Header().Set("Content-Type", "application/octet-stream")
228227
w.Header().Set("Content-Disposition", "attachment; filename=hello-world.txt")
229228
fmt.Fprint(w, "Hello World")
@@ -247,10 +246,9 @@ func TestRepositoriesService_DownloadReleaseAsset_Redirect(t *testing.T) {
247246
client, mux, _, teardown := setup()
248247
defer teardown()
249248

250-
acceptHeaders := []string{defaultMediaType, mediaTypeGraphQLNodeIDPreview}
251249
mux.HandleFunc("/repos/o/r/releases/assets/1", func(w http.ResponseWriter, r *http.Request) {
252250
testMethod(t, r, "GET")
253-
testHeader(t, r, "Accept", strings.Join(acceptHeaders, ", "))
251+
testHeader(t, r, "Accept", defaultMediaType)
254252
http.Redirect(w, r, "/yo", http.StatusFound)
255253
})
256254

@@ -268,10 +266,9 @@ func TestRepositoriesService_DownloadReleaseAsset_APIError(t *testing.T) {
268266
client, mux, _, teardown := setup()
269267
defer teardown()
270268

271-
acceptHeaders := []string{defaultMediaType, mediaTypeGraphQLNodeIDPreview}
272269
mux.HandleFunc("/repos/o/r/releases/assets/1", func(w http.ResponseWriter, r *http.Request) {
273270
testMethod(t, r, "GET")
274-
testHeader(t, r, "Accept", strings.Join(acceptHeaders, ", "))
271+
testHeader(t, r, "Accept", defaultMediaType)
275272
w.WriteHeader(http.StatusNotFound)
276273
fmt.Fprint(w, `{"message":"Not Found","documentation_url":"https://developer.github.com/v3"}`)
277274
})

0 commit comments

Comments
 (0)