Skip to content

Commit 25b0481

Browse files
Bowbaqwillnorris
authored andcommitted
Adding DownloadReleaseAsset
1 parent 9420d0f commit 25b0481

2 files changed

Lines changed: 84 additions & 0 deletions

File tree

‎github/repos_releases.go‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ package github
88
import (
99
"errors"
1010
"fmt"
11+
"io"
1112
"mime"
1213
"os"
1314
"path/filepath"
@@ -211,6 +212,29 @@ func (s *RepositoriesService) GetReleaseAsset(owner, repo string, id int) (*Rele
211212
return asset, resp, err
212213
}
213214

215+
// DownloadReleaseAsset downloads a release asset.
216+
//
217+
// DownloadReleaseAsset returns an io.ReadCloser that reads the contents of the
218+
// specified release asset. It is the caller's responsibility to close the ReadCloser.
219+
//
220+
// GitHub API docs : http://developer.github.com/v3/repos/releases/#get-a-single-release-asset
221+
func (s *RepositoriesService) DownloadReleaseAsset(owner, repo string, id int) (io.ReadCloser, error) {
222+
u := fmt.Sprintf("repos/%s/%s/releases/assets/%d", owner, repo, id)
223+
224+
req, err := s.client.NewRequest("GET", u, nil)
225+
if err != nil {
226+
return nil, err
227+
}
228+
req.Header.Set("Accept", defaultMediaType)
229+
230+
resp, err := s.client.client.Do(req)
231+
if err != nil {
232+
return nil, err
233+
}
234+
235+
return resp.Body, nil
236+
}
237+
214238
// EditReleaseAsset edits a repository release asset.
215239
//
216240
// GitHub API docs : http://developer.github.com/v3/repos/releases/#edit-a-release-asset

‎github/repos_releases_test.go‎

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@
66
package github
77

88
import (
9+
"bytes"
910
"encoding/json"
1011
"fmt"
12+
"io/ioutil"
1113
"net/http"
1214
"os"
1315
"reflect"
@@ -204,6 +206,64 @@ func TestRepositoriesService_GetReleaseAsset(t *testing.T) {
204206
}
205207
}
206208

209+
func TestRepositoriesService_DownloadReleaseAsset_Stream(t *testing.T) {
210+
setup()
211+
defer teardown()
212+
213+
mux.HandleFunc("/repos/o/r/releases/assets/1", func(w http.ResponseWriter, r *http.Request) {
214+
testMethod(t, r, "GET")
215+
testHeader(t, r, "Accept", defaultMediaType)
216+
w.Header().Set("Content-Type", "application/octet-stream")
217+
w.Header().Set("Content-Disposition", "attachment; filename=hello-world.txt")
218+
fmt.Fprint(w, "Hello World")
219+
})
220+
221+
reader, err := client.Repositories.DownloadReleaseAsset("o", "r", 1)
222+
if err != nil {
223+
t.Errorf("Repositories.DownloadReleaseAsset returned error: %v", err)
224+
}
225+
want := []byte("Hello World")
226+
content, err := ioutil.ReadAll(reader)
227+
if err != nil {
228+
t.Errorf("Repositories.DownloadReleaseAsset returned bad reader: %v", err)
229+
}
230+
if !bytes.Equal(want, content) {
231+
t.Errorf("Repositories.DownloadReleaseAsset returned %+v, want %+v", content, want)
232+
}
233+
}
234+
235+
func TestRepositoriesService_DownloadReleaseAsset_Redirect(t *testing.T) {
236+
setup()
237+
defer teardown()
238+
239+
mux.HandleFunc("/repos/o/r/releases/assets/1", func(w http.ResponseWriter, r *http.Request) {
240+
testMethod(t, r, "GET")
241+
testHeader(t, r, "Accept", defaultMediaType)
242+
w.Header().Set("Location", server.URL+"/github-cloud/releases/1/hello-world.txt")
243+
w.WriteHeader(http.StatusFound)
244+
})
245+
246+
mux.HandleFunc("/github-cloud/releases/1/hello-world.txt", func(w http.ResponseWriter, r *http.Request) {
247+
testMethod(t, r, "GET")
248+
w.Header().Set("Content-Type", "application/octet-stream")
249+
w.Header().Set("Content-Disposition", "attachment; filename=hello-world.txt")
250+
fmt.Fprint(w, "Hello World")
251+
})
252+
253+
reader, err := client.Repositories.DownloadReleaseAsset("o", "r", 1)
254+
if err != nil {
255+
t.Errorf("Repositories.DownloadReleaseAsset returned error: %v", err)
256+
}
257+
want := []byte("Hello World")
258+
content, err := ioutil.ReadAll(reader)
259+
if err != nil {
260+
t.Errorf("Repositories.DownloadReleaseAsset returned bad reader: %v", err)
261+
}
262+
if !bytes.Equal(want, content) {
263+
t.Errorf("Repositories.DownloadReleaseAsset returned %+v, want %+v", content, want)
264+
}
265+
}
266+
207267
func TestRepositoriesService_EditReleaseAsset(t *testing.T) {
208268
setup()
209269
defer teardown()

0 commit comments

Comments
 (0)