name: treat localhost as an explicit registry#2322
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This is ready for review. The name parser now treats localhost as an explicit registry, with updated registry/repository/tag coverage. The visible checks are green. |
Haihan-Jiang
force-pushed
the
codex/localhost-registry-name
branch
from
June 14, 2026 11:15
a77335c to
58da07e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2322 +/- ##
=======================================
Coverage 57.03% 57.03%
=======================================
Files 166 166
Lines 11442 11442
=======================================
Hits 6526 6526
Misses 4140 4140
Partials 776 776 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2048.
Docker-style image reference parsing treats the first path component as a registry when it contains
.or:, and also when it is exactlylocalhost.NewRepositoryonly handled the./:cases, solocalhost/testimage:mytagwas parsed as a Docker Hub repository path instead of usinglocalhostas the registry. That caused daemon lookups for Podman-tagged images such aslocalhost/testimage:mytagto resolve asindex.docker.io/localhost/testimage:mytag/docker.io/library/testimage:mytaginstead of the local daemon tag.This change recognizes
localhostas an explicit registry component and also makes the barelocalhostregistry use the samehttpscheme fallback aslocalhost:<port>.Test plan