fix(crane): avoid creating export tar on pull failure#2318
Merged
Subserial merged 2 commits intoJun 2, 2026
Conversation
Haihan-Jiang
marked this pull request as ready for review
May 24, 2026 08:41
Contributor
Author
|
This is ready for review from my side. Could someone take a look when convenient? |
Subserial
approved these changes
Jun 2, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2318 +/- ##
==========================================
+ Coverage 56.94% 57.02% +0.07%
==========================================
Files 166 166
Lines 11398 11398
==========================================
+ Hits 6491 6500 +9
+ Misses 4140 4131 -9
Partials 767 767 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2066
What changed
crane exportuntil after the source image has been loaded successfully.Why
crane export IMAGE out.tarpreviously created/truncatedout.tarbefore pullingIMAGE. If the pull failed, an empty or partial destination file could still be left behind.Validation
go test ./cmd/crane/cmdgo test ./cmd/crane/...git diff --check