feat(kubernetes): allow ignoring pull secrets#2315
Merged
Conversation
Subserial
approved these changes
Jun 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
=======================================
Coverage 57.02% 57.02%
=======================================
Files 166 166
Lines 11398 11398
=======================================
Hits 6500 6500
Misses 4131 4131
Partials 767 767 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2089
Summary
This adds an
IgnorePullSecretsoption to the Kubernetes keychain.Why
Some push-only workflows only want credentials from ServiceAccount mount secrets. Before this change, read-only credentials from explicit pull secrets or ServiceAccount
imagePullSecretscould be loaded first and selected for the same registry, causing push auth to fail even when a write credential was available in.secrets.Test plan
cd pkg/authn/kubernetes && go test ./...