fix(name): anchor loopback registry detection#2314
Merged
Subserial merged 2 commits intoJun 2, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
=======================================
Coverage 56.94% 56.94%
=======================================
Files 166 166
Lines 11369 11369
=======================================
Hits 6474 6474
Misses 4134 4134
Partials 761 761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Subserial
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2313
Summary
This anchors the loopback registry checks used by
Registry.Scheme().Before this change, any registry hostname containing
127.0.0.1or::1as a substring could be treated as loopback and use plain HTTP. Now only the actual loopback forms match:127.0.0.1,127.0.0.1:<port>,::1, and[::1]:<port>.Why
Non-loopback registries like
127.0.0.1.evil.comor[2001:db8::1]:5000should keep the default HTTPS scheme. The old unanchored regexes matched those strings accidentally.Test plan
go test ./pkg/namego test ./pkg/...