Skip to content

crane: Add timestamp to flatten layer#1974

Closed
nivbend wants to merge 2 commits into
google:mainfrom
nivbend:crane_flatten_timestamp
Closed

crane: Add timestamp to flatten layer#1974
nivbend wants to merge 2 commits into
google:mainfrom
nivbend:crane_flatten_timestamp

Conversation

@nivbend

@nivbend nivbend commented Jul 10, 2024

Copy link
Copy Markdown

When flattening an image the blob's created field is the same as the original image's, while the flattened layer's created field is a zero timestamp. This makes it impossible to figure out when was the flattened image actually created and distinguish it from the original.

Set both fields to the current time.

@google-cla

google-cla Bot commented Jul 10, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nivbend
nivbend force-pushed the crane_flatten_timestamp branch from 7bb1f47 to 0aa305c Compare August 11, 2024 10:48
@nivbend

nivbend commented Aug 11, 2024

Copy link
Copy Markdown
Author

Fixes #1996.

@github-actions

Copy link
Copy Markdown

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@nivbend

nivbend commented Nov 15, 2024

Copy link
Copy Markdown
Author

@imjasonh @thesayyn @jonjohnsonjr Would you have some time to review this minor fix? Much appreciated.

@github-actions

Copy link
Copy Markdown

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@Stephanie0829

Copy link
Copy Markdown
Contributor

Hi! I wanted to open a similar issue/PR. @jonjohnsonjr @Subserial @imjasonh Mind reviewing this so these changes can be merged (much appreciated)?

@brandonmichigangithub

Copy link
Copy Markdown

I'm going to close this as #2117 does the exact same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants