Fix DNS lookup failure caused by too-short dial timeout#1517
Closed
brandond wants to merge 1 commit intogoogle:mainfrom
Closed
Fix DNS lookup failure caused by too-short dial timeout#1517brandond wants to merge 1 commit intogoogle:mainfrom
brandond wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
x-ref: rancher/wharfie#11 |
If the user's primary nameserver is unavailable, and they are using the default resolver timeout of 5 seconds, the dial will fail before it can attempt to use any backup nameservers. This change raises the dial timeout to a value that should allow failover through multiple nameservers. With a value of 16 seconds, the 4th nameserver has 1 second to respond before the dial times out. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix_dns_timeout
branch
from
7ca6a5a to
d64d1d4
Compare
Collaborator
Author
|
That's great; a parallel ping would be preferred to just increasing the timeout again. |
Collaborator
|
Closing in favor of #1521, let me know if you still see issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user's primary nameserver is unavailable, and they are using the default resolver timeout of 5 seconds, the dial will fail before it can attempt to use any backup nameservers.
This change raises the dial timeout to a value that should allow failover through multiple nameservers. With a value of 16 seconds, the 4th nameserver has 1 second to respond before the dial times out.
Signed-off-by: Brad Davidson [email protected]