blob/azblob: feat added in MSI based authentication for Azure buckets#2873
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2873 +/- ##
==========================================
- Coverage 66.81% 66.54% -0.27%
==========================================
Files 116 116
Lines 11945 11990 +45
==========================================
- Hits 7981 7979 -2
- Misses 3301 3346 +45
- Partials 663 665 +2
Continue to review full report at Codecov.
|
chrismellard
force-pushed
the
master
branch
5 times, most recently
from
October 23, 2020 07:21
7f762be to
2050d02
Compare
Contributor
|
See my question on the bug. |
Contributor
Author
|
@vangent Couldn't see a specific question on the bug? I've rebased after the azure-storage-blob mod bump. Let me know what is outstanding please |
Contributor
|
vangent
self-requested a review
November 20, 2020 21:48
vangent
approved these changes
Nov 20, 2020
stanhu
added a commit
to stanhu/go-cloud
that referenced
this pull request
Dec 18, 2020
Prior to google#2873, setting the environment variable `AZURE_STORAGE_SAS_TOKEN` would work because the default behavior was to open the bucket via the environment. However, that pull request changed the behavior to only use the environment if an account key were provided, but the SAS token can be thought of as a temporary key. To fix this, we check whether an account key or a SAS token is provided. If one of them is available, open the container with the environment. Closes google#2933
stanhu
added a commit
to stanhu/go-cloud
that referenced
this pull request
Dec 18, 2020
Prior to google#2873, setting the environment variable `AZURE_STORAGE_SAS_TOKEN` would work because the default behavior was to open the bucket via the environment. However, that pull request changed the behavior to only use the environment if an account key were provided, but the SAS token can be thought of as a temporary key. To fix this, we check whether an account key or a SAS token is provided. If one of them is available, open the container with the environment. Closes google#2933
stanhu
added a commit
to stanhu/go-cloud
that referenced
this pull request
Dec 18, 2020
Prior to google#2873, setting the environment variable `AZURE_STORAGE_SAS_TOKEN` would work because the default behavior was to open the bucket via the environment. However, that pull request changed the behavior to only use the environment if an account key were provided, but the SAS token can be thought of as a temporary key. To fix this, we check whether an account key or a SAS token is provided. If one of them is available, open the container with the environment. Closes google#2933
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2870