rebase of #87

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d973f9) 63.92% compared to head (76c2c47) 64.19%.
Report is 3 commits behind head on master.

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   63.92%   64.19%   +0.27%     
==========================================
  Files          17       17              
  Lines        3326     3326              
  Branches     1125     1125              
==========================================
+ Hits         2126     2135       +9     
+ Misses        774      767       -7     
+ Partials      426      424       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thanks for the PR.

Could you please rebase and push the commit again as I no longer seem to have access to your branch after force pushing.

pretty sure you can fetch the commit you clobbered from the remote

$ git fetch https://github.com/vapier/glog 233df366d56df9d3d32898451f2ba1ace7e234de
$ git cherry-pick FETCH_HEAD

That's not the issue. I simply can't push to your master since the branch no longer contains the PR commit.

For future reference, please submit your changes from a dedicated feature branch to avoid confusion that local and remote branches with the same name can cause.

yeah, that's not really a thing. don't force push if you don't want to clobber/rewrite a ref.

i can rebase the original commit onto the latest branch & push to my repo again. but i can't re-open PR's in this project. i can only file new ones.

yeah, that's not really a thing. don't force push if you don't want to clobber/rewrite a ref.

What is not a thing? Force pushing is perfectly fine and necessary when rebasing which is what I did. I simply messed up the local ref when pushing.

This works now. Thanks.

requiring people use non-default branches to generate PRs to somehow protect against bad force pushes. you force pushed the wrong state to a remote branch. giving it a diff name wouldn't have helped -- you would have typed the remote branch in order to rewrite it.

but whatever, let's just agree to disagree and move on.

That's fine. I'm eager to learn.

giving it a diff name wouldn't have helped

Why not? Compare

git push [email protected]:vapier/glog.git master:master # whoops

vs

git push [email protected]:vapier/glog.git portable-labels

If you have a better suggestion how to avoid such a mishap, please let me know.