Fix targets for layering_check #916
Conversation
|
I'm a bit worried that this will break downstream projects by making private headers public. After this change, I think a downstream user of glog could Since the build error only comes from the unit test, which appears to depend on the private header, rather than from the library itself, it'd be better to fix the tests rather than changing the public interface. Do you know how we could do this? Unfortunately, my Bazel skills are super rusty, which makes me a not-very-good maintainer for this - so if you don't know how to fix it, I'd probably just disable the unit tests that depend on private headers. |
|
Thanks @drigz! That makes sense. I think we can move the shared headers to a filegroup and have the |
- TensorFlow: waiting on a fix for tensorflow/tensorflow#60508 - Cargo-Raze: broken by xcode 14.2, re-enable when we upgrade to Xcode 14.3, #1594 - Google logging: waiting on google/glog#916 - upb: https://github.com/protocolbuffers/upb/issues/1290
- TensorFlow: waiting on a fix for tensorflow/tensorflow#60508 - Cargo-Raze: broken by xcode 14.2, re-enable when we upgrade to Xcode 14.3, bazelbuild#1594 - Google logging: waiting on google/glog#916 - upb: https://github.com/protocolbuffers/upb/issues/1290
- TensorFlow: waiting on a fix for tensorflow/tensorflow#60508 - Cargo-Raze: broken by xcode 14.2, re-enable when we upgrade to Xcode 14.3, bazelbuild#1594 - Google logging: waiting on google/glog#916 - upb: https://github.com/protocolbuffers/upb/issues/1290
2 participants
Including headers that are not public in the dependencies broke the build with Bazel@Head because it violates layering_check error. This PR moves headers required by the test targets to
hdrsattribute of their direct dependencies.