Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Conversation

@sergiud
Copy link
Contributor

@sergiud sergiud commented Aug 18, 2022

Reverts #830

Fixes #854

@sergiud sergiud added the bug label Aug 18, 2022
@sergiud sergiud added this to the 0.7 milestone Aug 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #855 (0511d80) into master (bfee415) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
+ Coverage   73.28%   73.29%   +0.01%     
==========================================
  Files          17       17              
  Lines        3290     3292       +2     
==========================================
+ Hits         2411     2413       +2     
  Misses        879      879              
Impacted Files Coverage Δ
src/glog/logging.h.in 80.00% <100.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sergiud sergiud merged commit b70ea80 into master Aug 18, 2022
@sergiud sergiud deleted the revert-830-simplify_DLOG branch August 18, 2022 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible dangling else with DLOG in non-debug mode

2 participants