This repository was archived by the owner on Jun 30, 2025. It is now read-only.
SetLogger should delete previously set custom logger. #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As specified in the doc comment for SetLogger, "the logger becomes the property of the logging module and should not be deleted by the caller". Not only should the LogDestination delete a custom logger in its destructor, but it should also delete a previous logger when another logger is passed to SetLogger().
sergiud
suggested changes
Aug 13, 2022
Contributor
sergiud
left a comment
sergiud
left a comment
There was a problem hiding this comment.
Thank you! I have only a minor remark.
Co-authored-by: Sergiu Deitsch <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
==========================================
+ Coverage 73.17% 73.26% +0.08%
==========================================
Files 17 17
Lines 3277 3288 +11
==========================================
+ Hits 2398 2409 +11
Misses 879 879
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sergiud
approved these changes
Aug 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in the doc comment for
SetLogger, "the logger becomes the property of the logging module and should not be deleted by the caller".Not only should the
LogDestinationdelete a custom logger in its destructor, but it should also delete a previous logger when another logger is passed toSetLogger().