Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Strip only the first leading @ in repo name #832

Merged
drigz merged 1 commit into from
Jun 15, 2022
Merged

Strip only the first leading @ in repo name #832

drigz merged 1 commit into from
Jun 15, 2022

Conversation

@meteorcloudy
Copy link
Contributor

@meteorcloudy meteorcloudy commented Jun 15, 2022

This change is needed for glog to work with future version of Bazel when
canonical label literals is used in Bzlmod.

Context: https://docs.google.com/document/d/1N81qfCa8oskCk5LqTW-LNthy6EBrDot7bdUsjz6JFC4/edit#heading=h.5mcn15i0e1ch

@meteorcloudy
Copy link
Contributor Author

meteorcloudy commented Jun 15, 2022

/cc @Wyverald

@meteorcloudy meteorcloudy mentioned this pull request Jun 15, 2022
Merged
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022 •
edited
Loading

Codecov Report

Merging #832 (d4a6de5) into master (086ce22) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
- Coverage   73.14%   73.13%   -0.02%     
==========================================
  Files          17       17              
  Lines        3281     2963     -318     
==========================================
- Hits         2400     2167     -233     
+ Misses        881      796      -85
Impacted Files Coverage Δ
src/stacktrace_unwind-inl.h 25.00% <0.00%> (-67.86%) ⬇️
src/demangle.cc 97.37% <0.00%> (-0.11%) ⬇️
src/signalhandler.cc 6.38% <0.00%> (-0.07%) ⬇️
src/raw_logging.cc 100.00% <0.00%> (ø)
src/logging.cc 75.35% <0.00%> (+0.80%) ⬆️
src/symbolize.cc 66.66% <0.00%> (+2.54%) ⬆️
src/vlog_is_on.cc 72.89% <0.00%> (+2.66%) ⬆️
src/utilities.cc 71.30% <0.00%> (+3.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086ce22...d4a6de5. Read the comment docs.

@drigz
Copy link
Member

drigz commented Jun 15, 2022

Thanks! When canonical label literals is used in Bzlmod, will native.repository_name() return a canonical label like "@@foo.1.0.2"? Will $(GENDIR)/external/ contain a repository including a single @ symbol like external/@foo.1.0.2?

@meteorcloudy
Copy link
Contributor Author

meteorcloudy commented Jun 15, 2022

When canonical label literals is used in Bzlmod, will native.repository_name() return a canonical label like "@@foo.1.0.2"? Will $(GENDIR)/external/ contain a repository including a single @ symbol like external/@foo.1.0.2?

Yes, that is correct. Related Bazel change is bazelbuild/bazel@de37930

@drigz drigz merged commit 79d692c into google:master Jun 15, 2022
@Porkepix Porkepix mentioned this pull request Feb 17, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meteorcloudy @codecov-commenter @drigz