Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Conversation

@sergiud
Copy link
Contributor

@sergiud sergiud commented Dec 14, 2021

@sergiud sergiud added the bug label Dec 14, 2021
@sergiud sergiud added this to the 0.6 milestone Dec 14, 2021
@sergiud sergiud requested a review from drigz December 14, 2021 20:38
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.77%. Comparing base (d09b999) to head (4765234).
Report is 214 commits behind head on master.

Files with missing lines Patch % Lines
src/logging.cc 59.37% 13 Missing ⚠️
src/glog/logging.h.in 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   73.01%   72.77%   -0.25%     
==========================================
  Files          17       17              
  Lines        3217     3232      +15     
==========================================
+ Hits         2349     2352       +3     
- Misses        868      880      +12     
Files with missing lines Coverage Δ
src/utilities.h 100.00% <ø> (ø)
src/glog/logging.h.in 80.00% <50.00%> (-3.14%) ⬇️
src/logging.cc 73.49% <59.37%> (-0.38%) ⬇️

@sergiud sergiud merged commit dfb9ffc into master Dec 15, 2021
@sergiud sergiud deleted the log-message-time-compat branch December 15, 2021 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot declare variable ‘log’ to be of abstract type ‘testing::ScopedMockLog’

3 participants