Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

raw_logging.h depends on type definition in logging.h. #713

Merged
drigz merged 1 commit into from
Sep 24, 2021
Merged

raw_logging.h depends on type definition in logging.h. #713

drigz merged 1 commit into from
Sep 24, 2021

Conversation

@xkszltl
Copy link
Contributor

@xkszltl xkszltl commented Sep 23, 2021

Resolve #712

@google-cla google-cla bot added the cla: yes label Sep 23, 2021
@xkszltl xkszltl mentioned this pull request Sep 23, 2021
Closed
@drigz drigz requested a review from sergiud September 24, 2021 07:58
@drigz
Copy link
Member

drigz commented Sep 24, 2021

Thanks! Looks good, although I'll defer approval to Sergiu since my area is technically the Bazel support.

@drigz drigz merged commit 2412db3 into google:master Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sergiud sergiud sergiud approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing google::int32 in raw_logging.h.

3 participants

@xkszltl @drigz @sergiud