This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Add override to LogStreamBuf::overflow()
#576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
santigl
force-pushed
the
santigl/streambuf-overflow-override
branch
from
3fb7a75 to
f79373f
Compare
Contributor
Author
|
Thank you, @ukai. I added the change for the Windows code. |
Contributor
|
why continuous-integration/travis-ci/pr doesn't report check status?? |
Contributor
|
Good question. Also, this change introduces a dependency to C++11 while glog still uses C++03. A possible workaround is to remove the |
Prevents warnings such as:
```
glog/logging.h:1122:20: error: ‘virtual
std::basic_streambuf<char>::int_type
google::base_logging::LogStreamBuf::overflow(std::basic_streambuf<char>::int_type)’
can be marked override [-Werror=suggest-override]
virtual int_type overflow(int_type ch) {
^~~~~~~~
```
Signed-off-by: Santiago Gil <[email protected]>
santigl
force-pushed
the
santigl/streambuf-overflow-override
branch
from
f79373f to
7258189
Compare
Contributor
Author
I hadn't notice it was missing a check before. The last push successfully triggered it. |
Contributor
|
LGTM |
Contributor
Author
|
Thanks, @sergiud. Feel free to merge this whenever you want. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This quiets warnings such as: