This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Use NULL to indicate uninitialized VLOG_IS_ON site. #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it!
…On Apr 26 2020, at 11:02 pm, googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ ***@***.***/0?redirect=https%3A%2F%2Fcla.developers.google.com%2F&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLAIndividual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data ***@***.***/1?redirect=https%3A%2F%2Fcla.developers.google.com%2Fclas&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) and verify that your email is set on your git commits ***@***.***/2?redirect=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (http://go/cla#troubleshoot) (Public version ***@***.***/3?redirect=https%3A%2F%2Fopensource.google%2Fdocs%2Fcla%2F%23troubleshoot&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D)).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data ***@***.***/4?redirect=https%3A%2F%2Fcla.developers.google.com%2Fclas&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) and verify that your email is set on your git commits ***@***.***/5?redirect=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
The email used to register you as an authorized contributor must also be attached to your GitHub account ***@***.***/6?redirect=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
ℹ️ Googlers: Go here ***@***.***/7?redirect=https%3A%2F%2Fgoto.google.com%2Fprinfo%2Fhttps%253A%252F%252Fgithub.com%252Fgoogle%252Fglog%252Fpull%252F542&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub ***@***.***/8?redirect=https%3A%2F%2Fgithub.com%2Fgoogle%2Fglog%2Fpull%2F542%23issuecomment-619684063&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe ***@***.***/9?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEA4EHVGCDE3N3IIPAWTJHDROTYUVANCNFSM4MRRGQPQ&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
|
Collaborator
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the
kLogSiteUninitializedvariable and useNULLto indicate uninitilizedVLOG_IS_ONsite.