This repository was archived by the owner on Jun 30, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Use push/pop macro when supressing warning #397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kwaegel
commented
Nov 28, 2018
- Previous implementation did not correctly restore the warning state if initially disabled.
* Previous implementation did not correctly restore the warning state if initially disabled.
Collaborator
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Contributor
Author
|
Signed
…On Tue, Nov 27, 2018 at 5:38 PM googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google.com/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#397 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAae5dkNEHNnAHS_TGKEBfm-wwL1xx5hks5uzej3gaJpZM4Y2rTq>
.
|
Collaborator
|
CLAs look good, thanks! |
kwaegel
added a commit
to kwaegel/glog
that referenced
this pull request
Jan 22, 2019
* Same as PR google#397 , but for the `.in` file. Useful for some unusual cross-platform build environments (e.g. WSL).
shinh
added a commit
to shinh/glog
that referenced
this pull request
Jan 24, 2019
windows/glog/logging.h is expected to be generated by src/windows/preprocess.sh and should not be modified directly.
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
Use push/pop macro when supressing warning
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
* Same as PR google#397 , but for the `.in` file. Useful for some unusual cross-platform build environments (e.g. WSL).
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
windows/glog/logging.h is expected to be generated by src/windows/preprocess.sh and should not be modified directly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.