[RFC] reduce heap memory allocations to zero #158
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
sergiud
force-pushed
the
zero-allocation
branch
from
22949d2 to
63a9dca
Compare
sergiud
changed the title
sergiud
force-pushed
the
zero-allocation
branch
2 times, most recently
from
05e83e5 to
73203be
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
I confirm being okay with my commits being contributed to this project. |
|
@ukai Could you please take a look at this PR? |
shinh
left a comment
shinh
left a comment
There was a problem hiding this comment.
I put a comment but otherwise LGTM. I think this is a great idea. It'd be also great if ./configure supports this, too, but I don't think we need it in this PR. Thanks!
| thread_data_available = false; | ||
| data_ = new (&thread_msg_data) LogMessageData(); | ||
| } else { | ||
| allocated_ = new LogMessageData(); |
There was a problem hiding this comment.
I'd add a test case for this code path. Just
LOG(INFO) << LOG(INFO) << "nested LOG";
should be fine.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@shinh Done. Please review. |
[RFC] reduce heap memory allocations to zero
4 participants
In case there's thread-local storage (TLS) support, logging doesn't need to allocate memory for every message making it more memory efficient.