This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Set sinks_ to NULL after deletion in LogDestination::DeleteLogDestinations #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
I signed it! |
Collaborator
|
CLAs look good, thanks! |
Closed
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
Set sinks_ to NULL after deletion in LogDestination::DeleteLogDestinations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogDestination::DeleteLogDestinationsdeletessinks_but does not set the global toNULL.Further calls to
LogDestination::AddLogSinkwill incorrectly use the stalesinks_pointer and potentially crash (https://github.com/google/glog/blob/master/src/logging.cc#L621).This simple fix sets
sinks_toNULLafter thesinks_is deleted.