Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Conversation

@sergiud
Copy link
Contributor

@sergiud sergiud commented Jan 3, 2024

Fixes #590

@sergiud sergiud added the bug label Jan 3, 2024
@sergiud sergiud added this to the 0.7 milestone Jan 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.01%. Comparing base (51e7a43) to head (2f5e950).
Report is 86 commits behind head on master.

Files with missing lines Patch % Lines
src/logging.cc 53.33% 7 Missing ⚠️
src/signalhandler.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   58.75%   59.01%   +0.26%     
==========================================
  Files          18       18              
  Lines        2560     2550      -10     
  Branches      918      912       -6     
==========================================
+ Hits         1504     1505       +1     
+ Misses        707      701       -6     
+ Partials      349      344       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiud sergiud merged commit 54b2c17 into master Jan 3, 2024
@sergiud sergiud deleted the log-severity branch January 3, 2024 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can SetLogger set severity to -1?

2 participants