Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Logging UnitTest failed on x64 VS2015. Reason: Pointer format not consistent #134

@flm8620

Description

@flm8620

In logging_unittest.cc, we try to log a void* p = reinterpret_cast<void*>(0x12345678); in RAW_LOG(INFO, "ptr %p", p); format.
The golden file logging_unittest.err contains also a IDATE TIME__ THREADID logging_unittest.cc:LINE] RAW: ptr 0x12345678
When I build on x64 mode, outputs are:

Golden file string:

...
IDATE TIME__ THREADID logging_unittest.cc:LINE] RAW: ptr 12345678
...

Test generated string:

...
IDATE TIME__ THREADID logging_unittest.cc:LINE] RAW: ptr 0000000012345678
...

Which causes a fail.

By the way, diff command doesn't exist under Windows. Maybe test also for FC command, which gives a better experience for MSVC users.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions