stdcxx: eliminate excessive use of std::string::c_str()

anpol · sergiud · commit a8cfbe0c0c56 · 2021-12-30T12:55:45.000+01:00
It could be more clear and slightly more efficient not to convert an
`std::string` into a C-style string whenever possible.
diff --git a/src/googletest.h b/src/googletest.h
@@ -467,7 +467,7 @@ static inline void StringReplace(string* str,
                           const string& newsub) {
   size_t pos = str->find(oldsub);
   if (pos != string::npos) {
-    str->replace(pos, oldsub.size(), newsub.c_str());
+    str->replace(pos, oldsub.size(), newsub);
   }
 }
 
diff --git a/src/logging.cc b/src/logging.cc
@@ -1662,7 +1662,7 @@ void LogMessage::Init(const char* file,
     char fileline[128];
     snprintf(fileline, sizeof(fileline), "%s:%d", data_->basename_, line);
 #ifdef HAVE_STACKTRACE
-    if (!strcmp(FLAGS_log_backtrace_at.c_str(), fileline)) {
+    if (FLAGS_log_backtrace_at == fileline) {
       string stacktrace;
       DumpStackTraceToString(&stacktrace);
       stream() << " (stacktrace:\n" << stacktrace << ") ";
@@ -2290,7 +2290,7 @@ const vector<string>& GetLoggingDirectories() {
 
     if ( !FLAGS_log_dir.empty() ) {
       // A dir was specified, we should use it
-      logging_directories_list->push_back(FLAGS_log_dir.c_str());
+      logging_directories_list->push_back(FLAGS_log_dir);
     } else {
       GetTempDirectories(logging_directories_list);
 #ifdef GLOG_OS_WINDOWS

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,7 @@ static inline void StringReplace(string* str,`
`467`	`467`	`const string& newsub) {`
`468`	`468`	`size_t pos = str->find(oldsub);`
`469`	`469`	`if (pos != string::npos) {`
`470`		`- str->replace(pos, oldsub.size(), newsub.c_str());`
	`470`	`+ str->replace(pos, oldsub.size(), newsub);`
`471`	`471`	`}`
`472`	`472`	`}`
`473`	`473`