Remove requirements.txt file from repository#3
Merged
ondrasej merged 1 commit intogoogle:mainfrom May 28, 2023
Merged
Conversation
Having this file checked into the repository means that the ignore line in .gitignore is essentially nonfunctional. This patch removes requirements.txt so that the ignore line in .gitignore is functional and the generated requirements.txt doesn't accidentally end up in any commits.
Collaborator
|
I think I tried this and git still ignored changes made to the file, but ack. Creating the file is documented in README, so we don't really need it. |
boomanaiden154
added a commit
to boomanaiden154/rules_python
that referenced
this pull request
Jun 2, 2023
The documentation is currently ambiguous on whether or not to check requirements.txt into version control. This has raised some confusion in other projects (e.g., google/gematria#3). This makes it clear that requirements.txt files produced by this rule should be checked into version control in an easy to find place to avoid confusion.
boomanaiden154
added a commit
to boomanaiden154/rules_python
that referenced
this pull request
Jun 2, 2023
The documentation is currently ambiguous on whether or not to check requirements.txt into version control. This has raised some confusion in other projects (e.g., google/gematria#3). This makes it clear that requirements.txt files produced by this rule should be checked into version control in an easy to find place to avoid confusion.
github-merge-queue bot
pushed a commit
to bazel-contrib/rules_python
that referenced
this pull request
Jun 2, 2023
The documentation is currently ambiguous on whether or not to check requirements.txt into version control. This has raised some confusion in other projects (e.g., google/gematria#3). This makes it clear that requirements.txt files produced by this rule should be checked into version control in an easy to find place to avoid confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having this file checked into the repository means that the ignore line in .gitignore is essentially nonfunctional. This patch removes requirements.txt so that the ignore line in .gitignore is functional and the generated requirements.txt doesn't accidentally end up in any commits.