Merged
Conversation
While on unix systems it's easy to `time ./do <blah>`, on windows you need to have unix tools on the path.
dsrbecky
approved these changes
Jul 17, 2017
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
This bug may happen when AGI has Memory tab checked, but not put at front. When block memory UI tries to repaint, it will 1.check repainting area, 2. calculate repainting memory range accordingly, 3.query the server to load the memory range. In AGI, we have been using gc.getClipping() to do the step #1 for quite some time, but recently we find that it will not do #1 correctly when the Memory tab is hidden in the back, and thus the following steps will get wrong and cause incorrect server query. (It's possible but not sure, that SWT handles gc.getClipping() differently in newer version and thus this bug surfaces recently.) This PR tries to do the step #1 based on another data source and thus solve the problem. Test: This bug may happen when AGI has Memory tab checked, but not put at front. Reproduced on MacOS BigSur. Bug: b/181012589.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While on unix systems it's easy to
time ./do <blah>, on windows you need to have unix tools on the path.