Fix screen state logic for devices without NFC.#2819
Merged
pmuetschard merged 2 commits intogoogle:masterfrom Jun 7, 2019
Merged
Fix screen state logic for devices without NFC.#2819pmuetschard merged 2 commits intogoogle:masterfrom
pmuetschard merged 2 commits intogoogle:masterfrom
Conversation
Don't use the NFC service to determine screen state, as there are devices that don't have NFC, which will cause the "dumpsys nfc" command to fail.
If we fail to determine the screen state, ignore it, print a warning, and keep going. That is, only fail if we know the screen state and were unable to unlock.
hevrard
approved these changes
Jun 7, 2019
Contributor
hevrard
left a comment
hevrard
left a comment
There was a problem hiding this comment.
LGTM
Many thanks for this fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use the NFC service to determine screen state, as there are devices that don't have NFC, which will cause the "dumpsys nfc" command to fail.
Fixes #2736