Main Perfetto UI for System Profiling#2785
Merged
pmuetschard merged 4 commits intogoogle:masterfrom May 29, 2019
Merged
Conversation
The model allows running queries against a loaded Perfetto trace, but currently does no extra action on load.
AWoloszyn
reviewed
May 29, 2019
| disableReplayOptimization = | ||
| getBoolean(properties, "replay.disableOptimization", disableReplayOptimization); | ||
| reportCrashes = getBoolean(properties, "crash.reporting", reportCrashes); | ||
| perfettoSplitterWeights = |
Contributor
There was a problem hiding this comment.
We had some problems with negative splitter weights before (somehow...?)
Any chance we can pre-empt that issue here ?
Member
Author
There was a problem hiding this comment.
the negative splitter weights were only an issues with the tabs due to the custom handling there to allow tabs moving around. Here and in the other places where we use the splitter widget directly, the weights are already sanitized.
AWoloszyn
approved these changes
May 29, 2019
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
One comment in the middle, I THINK? the rest is ok.
It is a lot of code... so I cannot guarantee anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to take a perfetto trace, provide the UI with the desired Perfetto config protobuf in text format in a file passed via the
--perfettoflag.