Assert that cache load is a success#2756
Merged
hevrard merged 1 commit intogoogle:masterfrom May 17, 2019
Merged
Conversation
mCache->loadCache() should always succeed given that mCache->hasCache() had just returned true.
hevrard
force-pushed
the
fix-unread-variable
branch
from
14ff78d to
dd78424
Compare
pau-baiget
reviewed
May 16, 2019
| const auto& r = resources[i]; | ||
| // Check cache first | ||
| if (mCache->hasCache(r)) { | ||
| succeeded &= mCache->loadCache(r, static_cast<void*>(dst)); |
Contributor
There was a problem hiding this comment.
There was no check on "succeeded" at the end? Strange.
Contributor
There was a problem hiding this comment.
This was because
if (mCache->hasCache(r)) == true implies mCache->loadCache(r, static_cast<void*>(dst)); == true
And we have no other option if we cant actually load from the cache anyway (if it is in there), so asserting is likely the way to go.
pau-baiget
approved these changes
May 16, 2019
bjoeris
pushed a commit
to bjoeris/gapid
that referenced
this pull request
May 17, 2019
bjoeris
pushed a commit
to bjoeris/gapid
that referenced
this pull request
May 17, 2019
bjoeris
added a commit
to bjoeris/gapid
that referenced
this pull request
May 17, 2019
bjoeris
added a commit
that referenced
this pull request
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mCache->loadCache() should always succeed given that
mCache->hasCache() had just returned true.
Fix #2729