Merged
Conversation
Contributor
|
Linux and Windows builds still hit bazel errors apparently. |
pmuetschard
force-pushed
the
bazel25
branch
4 times, most recently
from
b3ba4ed to
42ba19d
Compare
Contributor
|
It's all green expect on Windows: I can't spot reference to 'androidsdk' in your changes, so maybe it's just Kokoro being flaky? I'll start a new kokoro build to see if it goes through. |
Now builds with go 1.12 (https://golang.org/doc/go1.12) which should result in better GC performance and memory usage.
- Get rid of our override BUILD file. - But, use our own way of defining the deps, but trim them down - Clean up the grpc proto code generation rules. I removed the TODO, as I don't think it's worth doing anymore.
This build file is symlinked into the local_cc_config workspace and only works there.
The go compiler requires about 8GB of RAM for the GLES and Vulkan packages. Since they often get built together at the same time, the build machine would run out of memory.
AWoloszyn
reviewed
May 18, 2019
| # Building GAPID | ||
|
|
||
| GAPID uses the [Bazel build system](https://bazel.build/). The current minimum required version of bazel is 0.18.1. | ||
| GAPID uses the [Bazel build system](https://bazel.build/). The current minimum required version of bazel is 0.25.1. |
Contributor
There was a problem hiding this comment.
Gross big jump. But I assume its basically impossible to avoid.
Member
Author
There was a problem hiding this comment.
The reality is that we were building with 0.20 before, but yeah, we should keep up with it a bit more.
AWoloszyn
approved these changes
May 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.