gapit: Add OutputCSV flag to benchmark (#2540).#2573
Merged
pau-baiget merged 3 commits intogoogle:masterfrom Feb 1, 2019
Merged
gapit: Add OutputCSV flag to benchmark (#2540).#2573pau-baiget merged 3 commits intogoogle:masterfrom
pau-baiget merged 3 commits intogoogle:masterfrom
Conversation
This flag produces a single row of comma-separated data. Also, all time information is expressed in milliseconds.
AWoloszyn
reviewed
Jan 30, 2019
cmd/gapit/benchmark.go
Outdated
| w.Flush() | ||
| if verb.OutputCSV { | ||
| csvWriter := csv.NewWriter(os.Stdout) | ||
| defer csvWriter.Flush() |
Contributor
There was a problem hiding this comment.
Defer is a bit funny (and you probably don't actually want it here) but defer actually defers until the end of the current function (NOT the scope-block).
How I typically handle this is:
if verb.OutputCSV {
func() {
csvWriter....
defer csvwriter.Flush()
....
....
} ()
} else {
...
Contributor
Author
There was a problem hiding this comment.
Ah! Ok, didn't know that. Will change it and resubmit.
Contributor
There was a problem hiding this comment.
It is super subtle, and goes completely against all of my past experience (thanks Go)
AWoloszyn
suggested changes
Jan 30, 2019
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
One small nit about defer, and the presubmit is failing, other than that, looks good to me.
AWoloszyn
approved these changes
Jan 31, 2019
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
Please make sure to squash before commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag produces a single row of comma-separated data.
Also, all time information is expressed in milliseconds.