Vulkan: sampler_ycbcr_conversion step 3, bind memory for planes#2543
Merged
qining merged 1 commit intogoogle:masterfrom Jan 17, 2019
Merged
Vulkan: sampler_ycbcr_conversion step 3, bind memory for planes#2543qining merged 1 commit intogoogle:masterfrom
qining merged 1 commit intogoogle:masterfrom
Conversation
AWoloszyn
approved these changes
Jan 17, 2019
Handle image plane memory bind (through vkBindImageMemory2). Memory requirements and bound memory info are combined in one map within an image object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #2538
Handle image plane memory binding (through vkBindImageMemory2).
Memory requirements and bound memory info are combined in one map,
indexed by plane bits, within an image object.
For non-disjoint multi-planar images, the memory requirements and bound
memory info are indexed with VkImageAspectFlagBits(0). But the
ImageLayer, ImageLevel, Layout info are stored in the
Aspectsmap, whichis indexed by the individual plane bits like:
VK_IMAGE_ASPECT_PLANE_0_BIT etc.