Vulkan: Support for external memory/fence/semaphore capabilities#2511
Merged
qining merged 2 commits intogoogle:masterfrom Jan 4, 2019
Merged
Vulkan: Support for external memory/fence/semaphore capabilities#2511qining merged 2 commits intogoogle:masterfrom
qining merged 2 commits intogoogle:masterfrom
Conversation
* VK_KHR_external_memory_capabilities * VK_KHR_external_semaphore_capabilities * VK_KHR_external_fence_capabilities TODO: we may need to cache those capabilities/properties later when we add real support for external handles.
qining
force-pushed
the
external-capabilities
branch
from
cff41b0 to
adbbd77
Compare
AWoloszyn
reviewed
Jan 3, 2019
gapis/api/vulkan/vulkan.api
Outdated
| @@ -193,6 +201,9 @@ sub ref!ExtensionSet supportedInstanceExtensions() { | |||
| supported.ExtensionNames["VK_KHR_win32_surface"] = true | |||
| supported.ExtensionNames["VK_KHR_get_physical_device_properties2"] = true | |||
| supported.ExtensionNames["Vk_KHR_get_surface_capabilities2"] = true | |||
Contributor
There was a problem hiding this comment.
I think these might be wrong?
Vk_KHR_external
AWoloszyn
suggested changes
Jan 3, 2019
Contributor
AWoloszyn
left a comment
AWoloszyn
left a comment
There was a problem hiding this comment.
I think the extension names are wrong?
AWoloszyn
approved these changes
Jan 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support just the capabilities extensions, not real support of external handles.
TODO: we may need to cache those capabilities/properties later when we
add real support for external handles.
PS: added several missing files also