Vulkan: Added Views field to ImageObject to store image views#2470
Merged
bjoeris merged 1 commit intogoogle:masterfrom Dec 14, 2018
Merged
Vulkan: Added Views field to ImageObject to store image views#2470bjoeris merged 1 commit intogoogle:masterfrom
Views field to ImageObject to store image views#2470bjoeris merged 1 commit intogoogle:masterfrom
Conversation
This means vkDestroyImage no longer needs to loop over all image views to find the views of the image being destroyed. This change breaks compatibility with old captures. Fixes google#2457
AWoloszyn
approved these changes
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means vkDestroyImage no longer needs to loop over all image views to find
the views of the image being destroyed.
This change breaks compatibility with old captures.
Fixes #2457